Link to libgcc for armv5te-unknown-linux-musleabi target.
#987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure this is something we should do since it's an upstream issue and will eventually be fixed hopefully. |
It is, it's already been patched (I submitted rust-lang/compiler-builtins#484 which was merged), but we need to wait for a stable release similar to what we do in aarch64-linux-musl-gcc.sh Similarly, we can remove |
Emilgardis
approved these changes
Aug 10, 2022
|
bors r=Emilgardis |
bors bot
added a commit
that referenced
this pull request
Aug 10, 2022
987: Link to libgcc for `armv5te-unknown-linux-musleabi` target. r=Emilgardis a=Alexhuszagh Fixes missing sync builtins required for libraries such as OpenSSL, specifically, the `__sync_X_and_fetch` builtins. Closes #367. Improves documentation related to #906. Co-authored-by: Alex Huszagh <[email protected]>
|
Build failed: |
Fixes missing sync builtins required for libraries such as OpenSSL, specifically, the `__sync_X_and_fetch` builtins.
Alexhuszagh
force-pushed
the
armv5te_musl_builtins
branch
from
252bda3 to
44184ec
Compare
Emilgardis
approved these changes
Aug 10, 2022
|
bors try --target mips64-unknown-linux-muslabi64 |
tryBuild succeeded: |
|
bors r=Emilgardis |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes missing sync builtins required for libraries such as OpenSSL, specifically, the
__sync_X_and_fetchbuiltins.Closes #367.
Improves documentation related to #906.