Update binutils to 2.38 on illumos and solaris #1641
Merged
+10
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahqsoftwares
changed the title
Closed
|
Can you squash the commits? Thanks! |
|
Actually, I'm not sure how to squash commits. Do I need to create another pr? |
|
To squash them, you can do |
|
I am not sure, is this correct? |
|
No that made it worse :D I can fix it for you |
|
/ci try --target *illumos |
This comment has been minimized.
This comment has been minimized.
Emilgardis
added
the
CI-x86_64-unknown-illumos
|
Can you do docker/solaris.sh too? |
This comment has been minimized.
This comment has been minimized.
|
/ci try --target *solaris |
This comment has been minimized.
This comment has been minimized.
Emilgardis
changed the title
This comment has been minimized.
This comment has been minimized.
|
Is the error related to the script or docker? The checksums match on wsl |
|
trying to parse the make build but can't see any obvious actual error, it's warning about makeinfo so trying now locally after adding texinfo |
Emilgardis
added
CI-sparcv9-sun-solaris
|
/ci try --target *solaris --target *illumos |
This comment has been minimized.
This comment has been minimized.
Try run for comment
Failed Jobs
Successful Jobs |
Emilgardis
removed
the
CI-sparcv9-sun-solaris
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1639