-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace all libz-sys code with flate2 #173
base: oxidize
Are you sure you want to change the base?
Conversation
There appear to be three things responsible for the diffs:
In any case, the PDFs all seem to open just fine. Zlib will always be able to decompress its own successful output. |
[features] | ||
default = ['libz-sys'] | ||
legacy-libz = ['libz-sys'] | ||
# to ensure binaries are not different, we link to libz-sys |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is inaccurate, I'm not sure there's really a backwards-compatibility point in keeping the zlib linking. I think the default backend runs about as quickly as zlib.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With default, every file is different.
Much less prone to errors; reads directly into pdf_stream
Vec<u8>
.Relevant: #171