ci: simplify linter configuration #156
kpetremannci.yml
on: pull_request
Lint and test
5m 45s
commitlint
1m 52s
Annotations
7 errors and 10 warnings
|
Lint and test:
internal/model/cmdb/routingpolicy/route_policy.go#L37
directive `//nolint:govet // for readability` is unused for linter "govet" (nolintlint)
|
|
Lint and test:
internal/report/report.go#L12
directive `//nolint:govet // for JSON order` is unused for linter "govet" (nolintlint)
|
|
Lint and test:
internal/api/auth/ldap.go#L57
directive `//nolint:reassign // we want to customize the default timeout` is unused for linter "reassign" (nolintlint)
|
|
Lint and test:
internal/convertor/bgp/bgp_test.go#L168
directive `//nolint:exhaustive // false positive` is unused for linter "exhaustive" (nolintlint)
|
|
Lint and test:
cmd/data-aggregation-api/main.go#L28
directive `//nolint:reassign // it is the way` is unused for linter "reassign" (nolintlint)
|
|
Lint and test:
cmd/data-aggregation-api/main.go#L30
directive `//nolint:reassign // it is the way` is unused for linter "reassign" (nolintlint)
|
|
Lint and test
issues found
|
|
commitlint
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Lint and test
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-go@v3, golangci/golangci-lint-action@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Lint and test:
internal/types/network.go#L26
indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (revive)
|
|
Lint and test:
internal/model/cmdb/bgp/global.go#L5
exported: type name will be used as bgp.BGPGlobal by other packages, and that stutters; consider calling this Global (revive)
|
|
Lint and test:
internal/ingestor/netbox/netbox.go#L17
exported: type name will be used as netbox.NetboxResponse by other packages, and that stutters; consider calling this Response (revive)
|
|
Lint and test:
internal/convertor/routingpolicy/routing_policy.go#L10
exported: func name will be used as routingpolicy.RoutingPolicyToOpenconfig by other packages, and that stutters; consider calling this ToOpenconfig (revive)
|
|
Lint and test:
internal/convertor/bgp/bgp.go#L10
exported: func name will be used as bgp.BGPToOpenconfig by other packages, and that stutters; consider calling this ToOpenconfig (revive)
|
|
Lint and test:
internal/convertor/bgp/global.go#L10
exported: func name will be used as bgp.BGPGlobalToOpenconfig by other packages, and that stutters; consider calling this GlobalToOpenconfig (revive)
|
|
Lint and test:
internal/convertor/device/serializer.go#L69
indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (revive)
|
|
Lint and test:
internal/convertor/device/serializer.go#L100
indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (revive)
|