Add support for using Remote Desktop Gateway servers. #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…+ (See https://www.donkz.nl/) Add settings for the gateway in same style as putty settings. ("key: value;key2: value2"). Sample: - rdgateway: my-gateway-hostname-or-ip; useSameCredentials: yes useSameCredentials is optional.
|
Hi @mterwoord, Thank you for this PR, but I'll need to make some changes before merging it:
Maybe:
What do you think? P.S. I'll also implement a native mode (using .rdp file) to connect using Remote Desktop Gateway (in a separate PR). |
|
You mean you are going to make those changes, or you want me to? regarding the points you mentioned:
The name of the setting: All for it, just thought, as the user has to enter it manually, we'd better use a simple name. |
|
If you want you can make those changes, but first you should check the fixes I’ve made to your PR. Didn’t had the time to test them.
Thanks.
…Sent from my Windows 10 phone
From: Matthijs ter Woord
Sent: Wednesday, May 17, 2017 9:15
To: cristianst85/QuickConnectPlugin
Cc: Cristian Stoica; Comment
Subject: Re: [cristianst85/QuickConnectPlugin] Add support for using RemoteDesktop Gateway servers. (#17)
You mean you are going to make those changes, or you want me to?
regarding the points you mentioned:
• New dialog: Sure, I just thought i'd extend the existing one.
• Tests is always good
• Code styling: I did my best to adhere to your style.
The name of the setting: All for it, just thought, as the user has to enter it manually, we'd better use a simple name.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
| RdpPlusOptions options; | ||
| if (RdpPlusOptionsParser.TryParse(hostPwEntry.AdditionalOptions, out options)) { | ||
| if (!string.IsNullOrEmpty(options.RDGateway)) { | ||
| var extraOptions = "gatewayhostname:s:" + options.RDGateway + ", gatewayusagemethod:i:2, gatewaycredentialssource:i:4, gatewayprofileusagemethod:i:1, gatewaybrokeringtype:i:0"; |
There was a problem hiding this comment.
I can't seem to find any references that the gatewaybrokeringtype parameter is supported by RDP+.
There was a problem hiding this comment.
Those are passed to the /o argument of RDP+, which basically means "pass this on to ms rdp".
What I did was save the rdp file from mstsc without gateway and with gateway, and added those options here.
cristianst85
force-pushed
the
master
branch
5 times, most recently
from
d13be9e to
a2c5358
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for using Remote Desktop Gateway servers. Works using Rdp+ (See https://www.donkz.nl/)
Add settings for the gateway in same style as putty settings. ("key: value;key2: value2").
Sample:
useSameCredentials is optional.
Specifying the path to Rdp+ should be done in the main settings form.
This PR fixes #16