Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update golangci-lint and config #243

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

saschagrunert
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Update the linter, its configuration and fix the lints.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

None

@openshift-ci openshift-ci bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jan 30, 2025
@openshift-ci openshift-ci bot requested review from haircommander and sameo January 30, 2025 10:09
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Signed-off-by: Sascha Grunert <[email protected]>
@coveralls
Copy link

coveralls commented Jan 30, 2025

Pull Request Test Coverage Report for Build 13050068087

Details

  • 36 of 60 (60.0%) changed or added relevant lines in 4 files are covered.
  • 16 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.1%) to 61.447%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tools/ocicnitool/ocicnitool.go 0 4 0.0%
pkg/ocicni/ocicni.go 34 54 62.96%
Files with Coverage Reduction New Missed Lines %
tools/ocicnitool/ocicnitool.go 2 0.0%
pkg/ocicni/ocicni.go 14 71.26%
Totals Coverage Status
Change from base Build 12903949434: -0.1%
Covered Lines: 569
Relevant Lines: 926

💛 - Coveralls

@saschagrunert
Copy link
Member Author

@cri-o/cri-o-maintainers PTAL

Copy link
Member

@sohankunkerkar sohankunkerkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2025
Copy link
Contributor

openshift-ci bot commented Jan 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert, sohankunkerkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 9619b9a into cri-o:master Jan 30, 2025
9 checks passed
@saschagrunert saschagrunert deleted the lint branch January 30, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants