Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logger and service providers fields initialization #529

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

guyp-descope
Copy link

The logger and serviceProviders fields of samlidp.Server object are not exported and therefor cannot be initialized when not using the default func New(opts Options) (*Server, error) ,
The fix include two things:

  1. Added InitializeLogger(..) function so logger can be initialized
  2. Added check for nil map before adding new serviceProvider which will initialized the map if needed.

@guyp-descope
Copy link
Author

Hi @crewjam, any feedback on this will be much appreciated. thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant