Brandon/cre 19 workflows #1347
Merged
Brandon/cre 19 workflows #1347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… template for flow as well
lorenzejay
requested changes
Sep 25, 2024
pyproject.toml
Outdated
| @@ -32,6 +32,7 @@ json-repair = "^0.25.2" | |||
| auth0-python = "^4.7.1" | |||
| poetry = "^1.8.3" | |||
| litellm = "^1.44.22" | |||
| graphviz = "^0.20.3" | |||
There was a problem hiding this comment.
src/crewai/flow/basic_flow.py
Outdated
| @@ -0,0 +1,52 @@ | |||
| import asyncio | |||
There was a problem hiding this comment.
do we need to commit this file?
src/crewai/flow/decorators.py
Outdated
| @@ -0,0 +1 @@ | |||
| # TODO: | |||
There was a problem hiding this comment.
should we remove this ? or havent pushed yet
lorenzejay
reviewed
Sep 25, 2024
src/crewai/flow/flow.py
Outdated
| dot.attr(bgcolor=colors["bg"]) | ||
|
|
||
| # Add nodes for each relevant method | ||
| for method_name, method in self._methods.items(): |
There was a problem hiding this comment.
should these be their own private methods ?
src/crewai/flow/flow.py
Outdated
| ) | ||
|
|
||
| # Add edges and enhanced router representation | ||
| for method_name, method in self._methods.items(): |
src/crewai/flow/flow.py
Outdated
| trigger, method_name, color=colors["edge"], penwidth="2" | ||
| ) | ||
|
|
||
| if method_name in self._routers.values(): |
src/crewai/flow/flow_graph.png
Outdated
| from crewai.flow.flow import Flow, listen, start | ||
|
|
||
|
|
||
| class FlexibleExampleFlow(Flow): |
There was a problem hiding this comment.
do we need all the examples here or better to add them as markdown in docs ?
lorenzejay
reviewed
Sep 25, 2024
src/crewai/flow/flow.py
Outdated
Comment on lines
261
to
269
| # Color scheme (using company colors) | ||
| colors = { | ||
| "bg": "#FFFFFF", | ||
| "start": "#FF5A50", | ||
| "method": "#333333", | ||
| "router_outline": "#FF5A50", | ||
| "edge": "#333333", | ||
| "text": "#FFFFFF", | ||
| } |
There was a problem hiding this comment.
should we have a utils for visualize?
|
Awesome work man ! 🔥 🔥 |
lorenzejay
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.