fix: fix bug in FindAllRoutes #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kingcre
requested review from
crypin,
richard-bachman and
lv-koala
as code owners
crypin
reviewed
Aug 8, 2023
There was a problem hiding this comment.
In simulation make test-sim-after-import, there seems to be a case of looping for more than 2 hours in the findMsgPlaceMarketOrderParams part
go test -mod=readonly ./app -run TestAppSimulationAfterImport -Enabled=true -NumBlocks=2 -Genesis= -Verbose=true -Commit=true -Seed=424254581 -Period=2
crypin
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was a bug in
FindAllRoutes- when there's two markets for same base/quote coin pair(e.g. bCRE/CRE and CRE/bCRE at the same time),FindAllRouteswould include only one of those markets in the result.This PR fixes the bug by making the
denomMapto have arrays of market ids instead of single market ids.