Skip to content
This repository has been archived by the owner on Jul 6, 2021. It is now read-only.

Recipient list management #44

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Recipient list management #44

wants to merge 1 commit into from

Conversation

cremich
Copy link
Owner

@cremich cremich commented Apr 29, 2021

Description

A very important feature to support onboarding new tenants will be, to give tenant managers the ability to upload and maintain recipient lists for each test pool. Those recipient lists are basically phone numbers we have to add as endpoints into Amazon Pinpoint. We have to keep in mind, that a phone number can be associated to multiple test pools but will be modeled as one endpoint in Pinpoint. A common use case for example in Kindergartens, where a mom or a dad has two kids in different groups.

Test Pool associations are modeled as endpoint attributes in pinpoint. So in a nutshell, a tenant manager must be able to

  • add phone numbers
  • associate phone numbers to test pools
  • delete phone numbers (in case of a request for deletion)

Fixes #39

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Added api infrastructure unit tests
  • Added tests to ensure dynamoDb table is provisioned correctly

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

feat: provide api to list and add recipients
@cremich cremich added the enhancement New feature or request label Apr 29, 2021
@cremich cremich added this to the 0.2.0 milestone Apr 29, 2021
Copy link
Collaborator

@Bakkenrak Bakkenrak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you plan on translating the changes in the recipient list table to pinpoint via DynamoDB streams and then lambda or something similar?

"address": $util.dynamodb.toDynamoDBJson($context.arguments.input.address)
},
"attributeValues": {
"pools" : $util.dynamodb.toDynamoDBJson($context.arguments.input.pools),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the way this is updated the frontend needs to take care of providing the full list of associated pools on an update request, right? When trying to imagine a dialog that would support this I'm wondering if it really fits the pool list management workflow I would prefer as a user.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recipient list management
2 participants