Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Upstreams #66

Merged
merged 24 commits into from
Mar 17, 2024
Merged

✨ Upstreams #66

merged 24 commits into from
Mar 17, 2024

Conversation

cfpwastaken
Copy link
Member

@cfpwastaken cfpwastaken commented Feb 22, 2024

Using remote POP/IMAP/SMTP servers as "upstreams".
Not to be confused with smtp relays. This is different.

@cfpwastaken cfpwastaken added the enhancement New feature or request label Feb 22, 2024
src/main.ts Fixed Show fixed Hide fixed
src/main.ts Fixed Show fixed Hide fixed
src/main.ts Fixed Show fixed Hide fixed
src/main.ts Fixed Show fixed Hide fixed
src/main.ts Fixed Show fixed Hide fixed
src/main.ts Fixed Show fixed Hide fixed
src/main.ts Fixed Show fixed Hide fixed
src/main.ts Fixed Show fixed Hide fixed
src/main.ts Fixed Show fixed Hide fixed
src/main.ts Fixed Show fixed Hide fixed
src/main.ts Fixed Show fixed Hide fixed
src/main.ts Fixed Show fixed Hide fixed
src/main.ts Fixed Show fixed Hide fixed
src/main.ts Fixed Show fixed Hide fixed
src/main.ts Fixed Show fixed Hide fixed
src/upstreams/POPUpstream.ts Fixed Show fixed Hide fixed
src/upstreams/POPUpstream.ts Fixed Show fixed Hide fixed
src/upstreams/POPUpstream.ts Fixed Show fixed Hide fixed
src/upstreams/POPUpstream.ts Fixed Show fixed Hide fixed
src/upstreams/POPUpstream.ts Fixed Show fixed Hide fixed
src/main.ts Fixed Show fixed Hide fixed
src/main.ts Fixed Show fixed Hide fixed
src/main.ts Fixed Show fixed Hide fixed
src/main.ts Fixed Show fixed Hide fixed
src/main.ts Fixed Show fixed Hide fixed
src/main.ts Fixed Show fixed Hide fixed
@cfpwastaken cfpwastaken marked this pull request as ready for review February 23, 2024 15:20
@cfpwastaken cfpwastaken self-assigned this Feb 23, 2024
src/pop3/POP3Commands.ts Fixed Show fixed Hide fixed
cfpwastaken and others added 2 commits February 24, 2024 16:21
- config keys that correspond to JSON objects or arrays are now supported
- dev dep version bump
Copy link
Member

@j0code j0code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was a lot to review.
Next time make smaller commits xD

config.sample.json Show resolved Hide resolved
src/imap/IMAPClient.ts Show resolved Hide resolved
src/main.ts Outdated Show resolved Hide resolved
config.sample.json Outdated Show resolved Hide resolved
src/pop3/POP3Client.ts Show resolved Hide resolved
src/smtp/SMTPClient.ts Show resolved Hide resolved
src/smtp/SMTPServer.ts Show resolved Hide resolved
src/upstreams/POPUpstream.ts Outdated Show resolved Hide resolved
src/upstreams/POPUpstream.ts Outdated Show resolved Hide resolved
src/upstreams/SMTPUpstream.ts Outdated Show resolved Hide resolved
src/upstreams/POP3Upstream.ts Fixed Show fixed Hide fixed
src/upstreams/SMTPUpstream.ts Fixed Show fixed Hide fixed
src/smtp/SMTPClient.ts Show resolved Hide resolved
src/upstreams/POP3Upstream.ts Outdated Show resolved Hide resolved
src/upstreams/SMTPUpstream.ts Outdated Show resolved Hide resolved
@cfpwastaken cfpwastaken requested a review from j0code March 17, 2024 17:24
Copy link
Member

@j0code j0code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sehr gut

@j0code
Copy link
Member

j0code commented Mar 17, 2024

ok, you may merge now.
I take no responsibility for broken code xd

@cfpwastaken
Copy link
Member Author

I'm still working on validation

Copy link
Member

@j0code j0code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve

@cfpwastaken cfpwastaken merged commit 678d0e6 into main Mar 17, 2024
7 checks passed
@cfpwastaken cfpwastaken deleted the f-upstreams branch March 17, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants