Skip to content

Commit

Permalink
Comment overrides of model checkpoint to monitor class. acc. instead …
Browse files Browse the repository at this point in the history
…of loss
  • Loading branch information
nathanpainchaud committed Nov 14, 2023
1 parent 96ee22c commit f281c2b
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 14 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@ task:
callbacks:
transformer_encoder_freeze:
finetune_layers: null
model_checkpoint:
monitor: val/acc/${list.at:${oc.dict.keys:task.predict_losses},0}
mode: max
# model_checkpoint:
# monitor: val/acc/${list.at:${oc.dict.keys:task.predict_losses},0}
# mode: max

# Change checkpoint loading defaults to:
ckpt: ??? # Make it mandatory to provide a checkpoint
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@ task:
callbacks:
transformer_encoder_freeze:
finetune_layers: []
model_checkpoint:
monitor: val/acc/${list.at:${oc.dict.keys:task.predict_losses},0}
mode: max
# model_checkpoint:
# monitor: val/acc/${list.at:${oc.dict.keys:task.predict_losses},0}
# mode: max

# Change checkpoint loading defaults to:
ckpt: ??? # Make it mandatory to provide a checkpoint
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@ task:
contrastive_loss_weight: 0
mtr_p: [ 0.3, 0 ]

callbacks:
model_checkpoint:
monitor: val/acc/${list.at:${oc.dict.keys:task.predict_losses},0}
mode: max
#callbacks:
# model_checkpoint:
# monitor: val/acc/${list.at:${oc.dict.keys:task.predict_losses},0}
# mode: max

hydra:
run:
Expand Down
8 changes: 4 additions & 4 deletions didactic/config/experiment/cardinal/xtab-finetune.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,10 @@ ckpt: ??? # Make it mandatory to provide a checkpoint
weights_only: True # Only load the weights and ignore the hyperparameters
strict: False # Only load weights where they match the defined network, to only some changes (e.g. heads, etc.)

callbacks:
model_checkpoint:
monitor: val/acc/${list.at:${oc.dict.keys:task.predict_losses},0}
mode: max
#callbacks:
# model_checkpoint:
# monitor: val/acc/${list.at:${oc.dict.keys:task.predict_losses},0}
# mode: max

hydra:
run:
Expand Down

0 comments on commit f281c2b

Please sign in to comment.