Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradient-Step denoiser blog post #207

Merged
merged 16 commits into from
Jan 24, 2025
Merged

Gradient-Step denoiser blog post #207

merged 16 commits into from
Jan 24, 2025

Conversation

Tmodrzyk
Copy link
Contributor

This paper is very math / optimization oriented. I try to go over the basics in the beginning of the post.
I don't know if I should add more details with regards to the actual mathematical proofs of the results presented in the article.

Copy link
Contributor

@PierreRouge PierreRouge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice review that goes beyond my area of expertise ;)

Copy link
Member

@nathanpainchaud nathanpainchaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just caught a few typos. Otherwise this is a great and well-explained review 🙂

collections/_posts/2025-01-18-GradientStepDenoiser.md Outdated Show resolved Hide resolved
collections/_posts/2025-01-18-GradientStepDenoiser.md Outdated Show resolved Hide resolved
collections/_posts/2025-01-18-GradientStepDenoiser.md Outdated Show resolved Hide resolved
collections/_posts/2025-01-18-GradientStepDenoiser.md Outdated Show resolved Hide resolved
collections/_posts/2025-01-18-GradientStepDenoiser.md Outdated Show resolved Hide resolved
collections/_posts/2025-01-18-GradientStepDenoiser.md Outdated Show resolved Hide resolved
collections/_posts/2025-01-18-GradientStepDenoiser.md Outdated Show resolved Hide resolved
collections/_posts/2025-01-18-GradientStepDenoiser.md Outdated Show resolved Hide resolved
@Tmodrzyk
Copy link
Contributor Author

Thanks for the review @nathanpainchaud, I'll just add a few references before you can merge the PR :)

Copy link
Member

@nathanpainchaud nathanpainchaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions to use Mardown's built-in syntax for footnotes + fix requested to titles of ref. 4 and 5.

collections/_posts/2025-01-18-GradientStepDenoiser.md Outdated Show resolved Hide resolved
collections/_posts/2025-01-18-GradientStepDenoiser.md Outdated Show resolved Hide resolved
collections/_posts/2025-01-18-GradientStepDenoiser.md Outdated Show resolved Hide resolved
collections/_posts/2025-01-18-GradientStepDenoiser.md Outdated Show resolved Hide resolved
collections/_posts/2025-01-18-GradientStepDenoiser.md Outdated Show resolved Hide resolved
collections/_posts/2025-01-18-GradientStepDenoiser.md Outdated Show resolved Hide resolved
collections/_posts/2025-01-18-GradientStepDenoiser.md Outdated Show resolved Hide resolved
collections/_posts/2025-01-18-GradientStepDenoiser.md Outdated Show resolved Hide resolved
@nathanpainchaud nathanpainchaud merged commit 60bdb24 into main Jan 24, 2025
2 checks passed
@nathanpainchaud nathanpainchaud deleted the gradient-step branch January 24, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants