-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gradient-Step denoiser blog post #207
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice review that goes beyond my area of expertise ;)
Co-authored-by: Pierre Rougé <[email protected]>
Co-authored-by: Pierre Rougé <[email protected]>
Co-authored-by: Pierre Rougé <[email protected]>
Co-authored-by: Pierre Rougé <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just caught a few typos. Otherwise this is a great and well-explained review 🙂
Co-authored-by: Nathan Painchaud <[email protected]>
Co-authored-by: Nathan Painchaud <[email protected]>
Co-authored-by: Nathan Painchaud <[email protected]>
Co-authored-by: Nathan Painchaud <[email protected]>
Co-authored-by: Nathan Painchaud <[email protected]>
Co-authored-by: Nathan Painchaud <[email protected]>
Co-authored-by: Nathan Painchaud <[email protected]>
Co-authored-by: Nathan Painchaud <[email protected]>
Thanks for the review @nathanpainchaud, I'll just add a few references before you can merge the PR :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestions to use Mardown's built-in syntax for footnotes + fix requested to titles of ref. 4 and 5.
Co-authored-by: Nathan Painchaud <[email protected]>
This paper is very math / optimization oriented. I try to go over the basics in the beginning of the post.
I don't know if I should add more details with regards to the actual mathematical proofs of the results presented in the article.