add auto unzip feature #39
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crccheck
reviewed
Jun 26, 2018
| @@ -9,6 +9,12 @@ const index = require('./') | |||
| const pkg = require('./package.json') | |||
|
|
|||
| const client = new AWS.Kinesis() | |||
| const zlib = require('zlib') | |||
|
|
|||
| const gzip_head = Buffer.from([0x1f, 0x8b]) | |||
There was a problem hiding this comment.
How about casing these like GZIP_HEAD so they look more like global constants instead of regular variables?
| @@ -28,7 +34,20 @@ program | |||
| program.args = [] | |||
| return | |||
| } | |||
| const options = {} | |||
| const options = { | |||
| parser: (buffer) => { | |||
There was a problem hiding this comment.
I'm not sure about this myself yet, buy my gut reaction is I wish this function was pulled out of the option parsing logic so what was left here read parser: decompressIfCompressed. That looks like a really long name but maybe you can think of a more elegant one.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatically detect compression and unzipped