Skip to content

Commit

Permalink
Update DEST_DIR_SUFFIX in case of pr
Browse files Browse the repository at this point in the history
Recently on crc side[0] we have enabled the regex to capture bundle info
and as part of this regex we are capturing the custom bundle which is
random generated number like
`crc_okd_vfkit_4.16.7_amd64_2342465234654.crcbundle` but for bundles
generated by the pr have suffix `.pr<pr_number>` which means again
adjust the regex. We can still identify the bundle with `_<pr_number>`
and this way we don't need to update the regex.

- crc-org/crc#4343
  • Loading branch information
praveenkumar authored and openshift-merge-bot[bot] committed Oct 25, 2024
1 parent 914f90f commit c43a7c3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion createdisk-library.sh
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ function get_dest_dir_suffix {
local version=$1
DEST_DIR_SUFFIX="${version}_${yq_ARCH}"
if [ -n "${PULL_NUMBER-}" ]; then
DEST_DIR_SUFFIX="$DEST_DIR_SUFFIX.pr${PULL_NUMBER}"
DEST_DIR_SUFFIX="${DEST_DIR_SUFFIX}_${PULL_NUMBER}"
fi
}

Expand Down

0 comments on commit c43a7c3

Please sign in to comment.