Skip to content

Commit

Permalink
chore : Update pull request template to remove link giving 404
Browse files Browse the repository at this point in the history
I received some feedback from @lilyLuLiu regarding pull request
template. Hence making some changes to accomodate these points:
- Development guide link got moved and was giving 404. However, having
  link to development guide doesn't help much at the time of creating
  the pull request. A contributor would be reading development guide
  only during the initial onboarding. It's not relevent to include it in
  pull request template in PR checklist.
- Changed the wording of sentence where PR author provides information
  about the platforms tested with the specified changes.

Signed-off-by: Rohan Kumar <[email protected]>
  • Loading branch information
rohanKanojia authored and praveenkumar committed Dec 23, 2024
1 parent 6d32a19 commit e119f1c
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,13 +47,11 @@ What is the _bottom-line_ functionality that needs testing? Describe in pseudo-c
-->

## Contribution Checklist
- [ ] I have read the [contributing guidelines](https://github.com/crc-org/crc/blob/main/developing.adoc)
- [ ] My code follows the style guidelines of this project
- [ ] I Keep It Small and Simple: The smaller the PR is, the easier it is to review and have it merged
- [ ] I have performed a self-review of my code
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] I tested my code on specified platforms <!-- Only put an `x` in applicable platforms -->
- [ ] Which platform have you tested the code changes on? <!-- Only put an `x` in applicable platforms -->
- [ ] Linux
- [ ] Windows
- [ ] MacOS

0 comments on commit e119f1c

Please sign in to comment.