Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests): add check for settings/preferences assets #400

Merged

Conversation

danivilla9
Copy link
Collaborator

Solves #399

@danivilla9 danivilla9 marked this pull request as ready for review November 11, 2024 12:34
@danivilla9 danivilla9 force-pushed the extend-installation-handling-test-case-399 branch 2 times, most recently from ccec386 to 73cd962 Compare November 11, 2024 12:40
tests/src/openshift-local-extension.spec.ts Outdated Show resolved Hide resolved
tests/src/openshift-local-extension.spec.ts Outdated Show resolved Hide resolved
tests/src/openshift-local-extension.spec.ts Outdated Show resolved Hide resolved
Signed-off-by: Daniel Villanueva <[email protected]>

chore(tests): putting test.fail() properly

Signed-off-by: Daniel Villanueva <[email protected]>

chore(tests): fixes on the assertions

Signed-off-by: Daniel Villanueva <[email protected]>

chore(tests): missing awaits

Signed-off-by: Daniel Villanueva <[email protected]>

chore(tests): check tab existence differently

Signed-off-by: Daniel Villanueva <[email protected]>

chore(tests): check inside settings/preferences

Signed-off-by: Daniel Villanueva <[email protected]>

chore(tests): missing not fixed

Signed-off-by: Daniel Villanueva <[email protected]>

chore(tests): ondrej's feedback

Signed-off-by: Daniel Villanueva <[email protected]>

chore(tests): removed redundant fail test case

Signed-off-by: Daniel Villanueva <[email protected]>

chore(tests): fixing test not failing?

Signed-off-by: Daniel Villanueva <[email protected]>

chore(tests): another test

Signed-off-by: Daniel Villanueva <[email protected]>

chore(tests): removed the wrong step...

Signed-off-by: Daniel Villanueva <[email protected]>

chore(tests): fixed linting issue

Signed-off-by: Daniel Villanueva <[email protected]>
@danivilla9 danivilla9 force-pushed the extend-installation-handling-test-case-399 branch from 8fbe577 to f2c47b0 Compare November 11, 2024 17:24
@danivilla9 danivilla9 requested a review from odockal November 11, 2024 17:33
@danivilla9 danivilla9 merged commit 7e7eced into crc-org:main Nov 12, 2024
6 checks passed
@danivilla9 danivilla9 deleted the extend-installation-handling-test-case-399 branch November 12, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] Add a Settings/Preferences check to extension handling test case
2 participants