Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix openssl missing cert bug for Linux & macOS #581

Merged
merged 2 commits into from
Dec 24, 2024

Conversation

crazywhalecc
Copy link
Owner

@crazywhalecc crazywhalecc commented Dec 24, 2024

What does this PR do?

Fix openssl missing cert bug for linux and macOS.

Probably fixes:

Introduction

I recently did some research between static-php and different distributions, maybe it is a better and permanent(maybe) solution to directly specify --openssldir=/etc/ssl when static-php builds static openssl.

Doing this will allow PHP to detect and use the same configuration and certificates as many system, and it should be hard to find an OS missing root certificates in 2024.

This path currently works well on common OS such as CentOS, Ubuntu, Debian, Alpine, macOS, etc., and adding it in static-php-cli should solve most OpenSSL cert problems, including FrankenPHP, Herd, NativePHP.

This issue has been going on for a long time, and now is the time to solve it once and for all.

cc @dunglas @simonhamp @mpociot

Checklist before merging

If your PR involves the changes mentioned below and completed the action, please tick the corresponding option.
If a modification is not involved, please skip it directly.

  • If it's an extension or dependency update, make sure adding related extensions in src/global/test-extensions.php.
  • If you changed the behavior of static-php-cli, update docs in ./docs/.
  • If you updated config/xxx.json content, run bin/spc dev:sort-config xxx.

@crazywhalecc crazywhalecc added bug Something isn't working kind/dependency Issues related to dependencies os/linux Things only for Linux OS labels Dec 24, 2024
@crazywhalecc crazywhalecc changed the title Fix openssl missing cert bug for linux Fix openssl missing cert bug for Linux & macOS Dec 24, 2024
@crazywhalecc crazywhalecc removed the os/linux Things only for Linux OS label Dec 24, 2024
@crazywhalecc crazywhalecc merged commit 4b16631 into main Dec 24, 2024
15 checks passed
@crazywhalecc crazywhalecc deleted the fix/openssl-linux-bug branch December 24, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working kind/dependency Issues related to dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant