Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent ghrel from downloading prerelease #240

Merged
merged 2 commits into from
Oct 18, 2023
Merged

Conversation

crazywhalecc
Copy link
Owner

Fix #239 .

@crazywhalecc crazywhalecc added bug Something isn't working kind/framework Issues related to CLI app framework labels Oct 18, 2023
@crazywhalecc crazywhalecc changed the title Fix ghrel prerelease Prevent ghrel from downloading prerelease. Oct 18, 2023
@crazywhalecc crazywhalecc changed the title Prevent ghrel from downloading prerelease. Prevent ghrel from downloading prerelease Oct 18, 2023
@DubbleClick
Copy link
Contributor

DubbleClick commented Oct 18, 2023

Maybe make sure that tags also don't contain 'beta' or 'rc', although this may be complicated.

@crazywhalecc
Copy link
Owner Author

crazywhalecc commented Oct 18, 2023

@DubbleClick libpng GitHub repo tag cannot get stable version, we still need hard-coded url to download it.

https://api.github.com/repos/glennrp/libpng/tags

It seems that the https://git.code.sf.net/p/libpng/code we are using now is the stable branch of libpng16.

@crazywhalecc crazywhalecc merged commit 8b188bd into main Oct 18, 2023
4 checks passed
@crazywhalecc crazywhalecc deleted the fix-ghrel-prerelease branch October 18, 2023 16:05
@DubbleClick
Copy link
Contributor

DubbleClick commented Oct 18, 2023

@DubbleClick libpng GitHub repo tag cannot get stable version, we still need hard-coded url to download it.

https://api.github.com/repos/glennrp/libpng/tags

It seems that the https://git.code.sf.net/p/libpng/code we are using now is the stable branch of libpng16.

If you check in the files it's downloading, it pulls the 1.6.41 version which is not released yet. 1.6.40 is the current stable version which is tagged on github/sourceforge.

Weird that the api returns all the 17.x versions. The normal link shows the 1.6.x tags: https://github.com/glennrp/libpng/tags

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working kind/framework Issues related to CLI app framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ghrel source pulls pre-releases
2 participants