-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run tests in qemu in GitHub action #79
base: main
Are you sure you want to change the base?
Run tests in qemu in GitHub action #79
Conversation
@crazii I opened it as a "draft pull request" this time, so that it can't accidentally get prematurely merged. 😅 This has been rebased on your previous revert push that fixed the release pipeline. 👍 |
075013a
to
5b74172
Compare
Okay, The 01 pipeline (build release) is now also working again in this PR. See actions results here: https://github.com/volkertb/SBEMU/actions/workflows/01-build-and-release.yml |
Still keeping this PR as draft, since the exit/error codes of failing DOS actions (specifically |
5b74172
to
b2d7440
Compare
…oesn't have to be downloaded and installed in each pipeline
…ase workflow (best to remove `branches` block before merging, to have this workflow triggered only on pushed tags)
Co-authored-by: Thomas Perl <[email protected]>
Co-authored-by: Thomas Perl <[email protected]>
…in PR Checks workflow, so the build container image does not have to include it
…n `ubuntu-latest` by default, apparently
…b Actions directly
…cess to /dev/kvm for KVM support
… (verify that args are actually being passed on when running docker)
…I can't prevent the entrypoint from being overridden by the steps, apparently)
…rypoint of the Docker image would run
…Hub Actions Workflow, as a sanity test (will extend this test further later)
…ake test job dependent on build job, since build job needs to complete and upload SBEMU.EXE as artifact before test job can download and run it
…, DOS/32A DOS extender and DTMF tone test WAV file to test directory for testing actual sound output
…so the test job has access to all the necessary files for running the tests in the DOS VM
eca0d35
to
726fbd2
Compare
…is apparently not working with SBEMU in the QEMU VM, at least not for the stp32 Protected Mode audio player
6e41a9c
to
0e0000c
Compare
Update:
@crazii It was already known that there was an issue with DOS/32A (the VCPI issue that you and @viti95 encountered in FastDoom), but I suspect that this might not be the only compatibility issue between DOS/32A and DOSEMU, since this test also fails when I don't have JEMM loaded, in which case VCPI should not be enabled either. Anway, the test is working, so this PR is ready to be merged. In a subsequent PR, I'll make this into two tests, one that tests SBEMU with HDA and another that tests SBEMU with AC'97/ICHx (both which QEMU can emulate). I'll also add tests for real mode emulation later, since this test currently only tests SBEMU emulation with a protected mode application. |
a0f8097
to
dfd3fe9
Compare
…g it, since we are testing on an Alpine image, not an Ubuntu or Debian image
dfd3fe9
to
b273180
Compare
…ile, since the output file isn't yielding any DTMF tones, according to the dtmf2num tool
… latter is apparently not working with SBEMU in the QEMU VM, at least not for the stp32 Protected Mode audio player" This reverts commit 0e0000c.
… to AC'97/ICHx in the previous commit
…acts, for manual analysis
…t emulation in Real Mode (or rather V8086 mode) and temporarily comment out Protected Mode playback with STP32.EXE
5f51882
to
1420eb9
Compare
… tested it in a Docker container manually
…ble, so the if-statement further below has it in its context
60f0969
to
b4d6c42
Compare
…ose are reserved characters in YAML
…w the previous if-statement was interpeted
… code propagation (i.e. the line with the if-statement)
No description provided.