Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error matching on missing EOF #114

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Improve error matching on missing EOF #114

merged 1 commit into from
Oct 30, 2024

Conversation

surister
Copy link
Collaborator

Summary of the changes / Why this is an improvement

Changes how we heuristically match queries on missing error context.

Fixes #113

@cla-bot cla-bot bot added the cla-signed label Oct 30, 2024
@surister
Copy link
Collaborator Author

all green feelsgoodman

@surister surister requested review from kneth and amotl and removed request for kneth October 30, 2024 16:10
amotl
amotl approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@amotl amotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@amotl
Copy link
Member

amotl commented Oct 30, 2024 •
edited
Loading

Thank you. Maybe add a changelog item?

@surister
Copy link
Collaborator Author

surister commented Oct 30, 2024 •
edited
Loading

Thank you. Maybe add a changelog item?

yeah i kind of forgot haha, thanks

@surister surister merged commit e9e1ed8 into crate:main Oct 30, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amotl amotl amotl approved these changes

@kneth kneth Awaiting requested review from kneth

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Query with missing semi-colon gets wrongfully parsed
2 participants
@surister @amotl