Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] Add Node.js feature #67

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

[DRAFT] Add Node.js feature #67

wants to merge 11 commits into from

Conversation

Taliik
Copy link
Member

@Taliik Taliik commented Jun 30, 2017

No description provided.

@Taliik Taliik requested a review from joemoe June 30, 2017 09:33
Copy link
Member

@amotl amotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Taliik,

it looks like @lukasbals added a showcase implementation for Node.js at 1 already. I did not scan both implementations too closely, maybe your variant includes important details not addressed by the other one from @lukasbals?

Otherwise, let's close this PR?

With kind regards,
Andreas.

Footnotes

  1. https://github.com/crate/crate-sample-apps/tree/master/nodejs

"license": "Apache-2.0",
"dependencies": {
"express": "^4.15.3",
"node-crate": "^2.0.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like node-crate is unmaintained 1. What about switching to the canonical node-postgres 2 today?

Footnotes

  1. https://www.npmjs.com/package/node-crate

  2. https://www.npmjs.com/package/pg

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Contrary to my previous assessment, it looks like node-crate is well alive and maintained 1.

Footnotes

  1. https://github.com/megastef/node-crate

@amotl amotl changed the title added node.js feature [DRAFT] Add Node.js feature Jan 11, 2023
@amotl amotl marked this pull request as draft January 11, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants