Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated user modification operations to leverage parameterized queries #587

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Updated user modification operations to leverage parameterized queries #587

merged 1 commit into from
Feb 6, 2024

Conversation

proddata
Copy link
Member

@proddata proddata commented Feb 5, 2024 •
edited
Loading

Summary of changes

Updated user modification operations to leverage parameterized queries and
curl, replacing direct usage of crash. Might also want to replace the remaining crash queries. crash unfortunately doesn't support parameterized queries.

resolves: https://github.com/crate/cloud/issues/1671

Checklist

  • Relevant changes are reflected in CHANGES.rst
  • Added or changed code is covered by tests
  • Documentation has been updated if necessary
  • Changed code does not contain any breaking changes (or this is a major version change)

@proddata proddata force-pushed the proddata/parameterized-user-operations branch from 2bf5b01 to 09a5561 Compare February 5, 2024 19:13
@proddata proddata closed this Feb 5, 2024
@proddata proddata reopened this Feb 5, 2024
@proddata proddata marked this pull request as draft February 5, 2024 19:28
SStorm
SStorm approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@SStorm SStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please test in dev 👍

crate/operator/bootstrap.py Outdated Show resolved Hide resolved
@proddata proddata force-pushed the proddata/parameterized-user-operations branch 3 times, most recently from 0a93c7c to 03a0321 Compare February 6, 2024 10:14
@proddata proddata marked this pull request as ready for review February 6, 2024 10:14
@proddata proddata force-pushed the proddata/parameterized-user-operations branch from 03a0321 to 5e4115a Compare February 6, 2024 12:24
@proddata proddata force-pushed the proddata/parameterized-user-operations branch from 41ae9e9 to fe06f45 Compare February 6, 2024 15:49
@proddata proddata merged commit ee0b910 into master Feb 6, 2024
5 checks passed
@proddata proddata deleted the proddata/parameterized-user-operations branch February 6, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SStorm SStorm SStorm approved these changes

@plaharanne plaharanne Awaiting requested review from plaharanne

@tomach tomach Awaiting requested review from tomach

@WalBeh WalBeh Awaiting requested review from WalBeh

@Taliik Taliik Awaiting requested review from Taliik

@juanpardo juanpardo Awaiting requested review from juanpardo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@proddata @SStorm