Add nodepool to the CRD
#553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomach
force-pushed
the
ta/crd-add-nodepool
branch
from
655be1a
to
5f32c35
Compare
tomach
force-pushed
the
ta/crd-add-nodepool
branch
from
5f32c35
to
8b0d3f8
Compare
tomach
requested review from
plaharanne,
WalBeh,
Taliik,
juanpardo and
SStorm
as code owners
SStorm
approved these changes
Nov 3, 2023
crate/operator/create.py
Outdated
| if not (cpu_request or memory_request): | ||
| return False | ||
| return cpu_request != cpu_limit or memory_request != memory_limit | ||
| return ( |
There was a problem hiding this comment.
I guess the question is whether we need to check the requests/limits at all anymore? It might be a bit counter-intuitive, because if your requests/limits do not differ, but you still specify shared for the nodepool, it will ignore that and put it to the dedicated one?...
There was a problem hiding this comment.
hm you're right. I can't think of a case where both checks are needed either.
If I understand correctly, if nodepool is not specified, we will always default to dedicated, right?
yes. if no nodepool is specified, it defaults to the tolerations and affinity of the dedicated one.
tomach
force-pushed
the
ta/crd-add-nodepool
branch
2 times, most recently
from
4d06a62
to
d53aeb1
Compare
tomach
force-pushed
the
ta/crd-add-nodepool
branch
from
d53aeb1
to
e788d49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Add optional
nodepoolto the node's CRD and set node affinity and tolerations accordingly when creating a cluster or changing its compute.https://github.com/crate/cloud/issues/1502
Checklist
CHANGES.rst