Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly lowering TCP keepalives to 120s to deal with naughty load balancers #548

Merged
merged 1 commit into from
Sep 8, 2023
Merged

Explicitly lowering TCP keepalives to 120s to deal with naughty load balancers #548

merged 1 commit into from
Sep 8, 2023

Conversation

SStorm
Copy link
Contributor

@SStorm SStorm commented Sep 6, 2023 •
edited
Loading

Summary of changes

Looking at you, AWS NLB.

https://github.com/crate/cloud/issues/1473

Checklist

  • Relevant changes are reflected in CHANGES.rst
  • Added or changed code is covered by tests
  • Documentation has been updated if necessary
  • Changed code does not contain any breaking changes (or this is a major version change)

This was referenced Sep 6, 2023
Closed
Closed
amotl
amotl approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@amotl amotl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This will address GH-117, at least partially, as far as I can see.

@SStorm SStorm merged commit 383c5f4 into master Sep 8, 2023
5 checks passed
@SStorm SStorm deleted the r/tcp-keepalive branch September 8, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amotl amotl amotl approved these changes

@plaharanne plaharanne Awaiting requested review from plaharanne

@tomach tomach Awaiting requested review from tomach

@WalBeh WalBeh Awaiting requested review from WalBeh

@Taliik Taliik Awaiting requested review from Taliik

@juanpardo juanpardo Awaiting requested review from juanpardo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SStorm @amotl