Increase timeout for querying snapshots table #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SStorm
approved these changes
Aug 29, 2023
| @@ -871,16 +879,15 @@ async def handle( # type: ignore | |||
| get_host(core, namespace, name), | |||
| ) | |||
| conn_factory = connection_factory(host, password) | |||
| async with conn_factory() as conn: | |||
| async with conn.cursor() as cursor: | |||
There was a problem hiding this comment.
Could have also set the timeout globally here perhaps? Would have made a smaller diff! :)
There was a problem hiding this comment.
yes, but then the timeout would be increased for everything in validate_restore_complete() like querying sys.shards etc. not sure if we want that?
The diff should become smaller once I merge the other branch into master - I just needed that code as a base here :)
There was a problem hiding this comment.
I don't think it matters that much, the one minute timeout is a bit arbitrary, same as 2 minutes! Up to you entirely, I already approved it.
tomach
force-pushed
the
ta/fix-snapshots-timeout
branch
from
cfdaa0e
to
f8db230
Compare
tomach
requested review from
plaharanne,
WalBeh,
Taliik and
juanpardo
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Fixes https://github.com/crate/cloud/issues/1362
Checklist
CHANGES.rst