Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed cloning empty partitioned table #543

Merged
merged 2 commits into from
Aug 17, 2023
Merged

Fixed cloning empty partitioned table #543

merged 2 commits into from
Aug 17, 2023

Conversation

juanpardo
Copy link
Contributor

Summary of changes

An additional check query is made to ensure cloning empty partitioned tables can be cloned successfully.

Checklist

  • Relevant changes are reflected in CHANGES.rst
  • Added or changed code is covered by tests
  • Documentation has been updated if necessary
  • Changed code does not contain any breaking changes (or this is a major version change)

SStorm
SStorm approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@SStorm SStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to add a comment why we're doing this.

@juanpardo juanpardo merged commit 8e53998 into master Aug 17, 2023
4 checks passed
@juanpardo juanpardo deleted the jp/clone-empty-partitioned-table branch August 17, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SStorm SStorm SStorm approved these changes

@plaharanne plaharanne Awaiting requested review from plaharanne

@tomach tomach Awaiting requested review from tomach

@WalBeh WalBeh Awaiting requested review from WalBeh

@Taliik Taliik Awaiting requested review from Taliik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juanpardo @SStorm