Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed deleting a cluster while restoring/cloning #539

Merged
merged 3 commits into from
Jul 21, 2023

Conversation

juanpardo
Copy link
Contributor

Summary of changes

Checklist

  • Relevant changes are reflected in CHANGES.rst
  • Added or changed code is covered by tests
  • Documentation has been updated if necessary
  • Changed code does not contain any breaking changes (or this is a major version change)

Copy link
Contributor

@SStorm SStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice solution! Should we make this generic and perhaps move this check into each of the top level handlers in main.py? Even though we've only seen this happen for restore operations, I suspect it can theoretically happen for any?

@juanpardo
Copy link
Contributor Author

Very nice solution! Should we make this generic and perhaps move this check into each of the top level handlers in main.py? Even though we've only seen this happen for restore operations, I suspect it can theoretically happen for any?

I was expecting you to say that :)
Will add it to this PR

@juanpardo juanpardo merged commit 79b3cd2 into master Jul 21, 2023
4 checks passed
@juanpardo juanpardo deleted the jp/restore-delete-fix branch July 21, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants