feat: add phpstan and fix deprecations in dbal #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulianMar
changed the title
* reverts some changes and keeps some deprecations
JulianMar
force-pushed
the
feature/update-dbal
branch
from
4cdfaab
to
939399e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes / Why this is an improvement
Add PHPStan to help with moving from DBAL 2 to the current version. We can first fix up all the deprecations and move from there:
Issues:
The fetch Syntax is a bit different and some fetch modes are not supported anymore. FETCH_BOTH is not supported and I guess will not be supported. I don't know the usecase for this fetch mode maybe someone can enlighten me and tell me why it's needed? Maybe we don't even need it anymore.
See here.
Checklist