Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old .io links #134

Merged
merged 4 commits into from
Apr 29, 2024
Merged

Remove old .io links #134

merged 4 commits into from
Apr 29, 2024

Conversation

matkuliak
Copy link
Contributor

@matkuliak matkuliak commented Apr 29, 2024

Summary of the changes / Why this is an improvement

  • There's a bunch of ".io" link from old website, this removes them
  • Bump build.json to 2.1.2

Checklist

  • Link to issue this PR refers to (if applicable):
  • CLA is signed

@matkuliak matkuliak added the docs A documentation issue label Apr 29, 2024
@matkuliak matkuliak requested review from amotl and msbt April 29, 2024 15:50
@msbt
Copy link
Contributor

msbt commented Apr 29, 2024

@matkuliak thanks, but why are we linking to master? Default should be the latest version, right? There are also a few broken links (https://github.com/crate/crate-dbal/actions/runs/8881555454/job/24384190703?pr=134#step:4:416 downwards)

@matkuliak
Copy link
Contributor Author

matkuliak commented Apr 29, 2024

Right, fixed to latest.
@amotl took care of the errors in #135

Copy link
Member

@amotl amotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Can you squash your four commits into a single one with a corresponding sensible commit message like Chore: s/crate.io/cratedb.com/? Thanks!

This branch cannot be rebased due to conflicts.

Apparently, the branch also needs a clean rebase on top of current main.

@matkuliak matkuliak merged commit e04fa0b into main Apr 29, 2024
8 checks passed
@matkuliak matkuliak deleted the mm/crateio-link-fixes branch April 29, 2024 20:32
@matkuliak
Copy link
Contributor Author

Should be good now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs A documentation issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants