Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for PHP 7.x #129

Merged
merged 4 commits into from
Feb 1, 2024
Merged

Drop support for PHP 7.x #129

merged 4 commits into from
Feb 1, 2024

Conversation

amotl
Copy link
Member

@amotl amotl commented Feb 1, 2024

About

Drop support for PHP 7.x, it is EOL. See https://www.php.net/supported-versions.php.

Details

Firstly, an unqualified / trial-and-error attempt to resolve GH-128.
Now, the outcome also relates to crate/crate-pdo#152.

@amotl amotl force-pushed the amo/fix-tests branch 4 times, most recently from e39d0d1 to 2f9e68d Compare February 1, 2024 10:34
@amotl amotl changed the title Use older version of Composer Drop support for PHP 7.x Feb 1, 2024
@amotl amotl marked this pull request as ready for review February 1, 2024 11:36
@hlcianfagna
Copy link

Fixes #126 ?

composer.json Show resolved Hide resolved
.github/workflows/tests.yml Show resolved Hide resolved
@amotl
Copy link
Member Author

amotl commented Feb 1, 2024

Fixes #126?

Not yet ;]. The title would be a mismatch. GH-130 has the update to PHP 8.3.

@amotl amotl merged commit 2c6f3da into main Feb 1, 2024
7 checks passed
@amotl amotl deleted the amo/fix-tests branch February 1, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHP Fatal error: Uncaught Declaration of PDOCrateDB::prepare should be compatible with PDO::prepare
2 participants