Maintenance: Improve CI/GHA, satisfy link checker, improve code style #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- CrateDB enterprise license is no more. - Linking to local HTML pages within .rst pages will not work.
amotl
changed the title
amotl
commented
Apr 11, 2022
| @@ -8,7 +8,7 @@ jobs: | |||
| runs-on: ${{ matrix.os }} | |||
| strategy: | |||
| matrix: | |||
| os: [ubuntu-latest] | |||
| os: [ubuntu-latest, macos-latest, windows-2019] | |||
There was a problem hiding this comment.
I found that using windows-2019 instead of windows-2022, which happened to become windows-latest just recently, significantly improves runtime, so I also submitted crate/crate#12344.
There was a problem hiding this comment.
^^ Doesn't help on the CrateDB test suite. 😞
.github/workflows/main.yml
Outdated
Comment on lines
28
to
29
| isort --recursive --check --diff crate/ tests/ setup.py | ||
| flake8 crate/crash |
There was a problem hiding this comment.
Apologies. Dropped commit 7bd8d9f 👍.
mfussenegger
approved these changes
Apr 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
this patch intended to slightly adjust the CI/GHA configuration and satisfy the documentation link checker. After discovering some more flaws and potential improvements on infrastructure and code style, more commits have been added.
Tests
CRATEDB_VERSIONenvironment variable, defaulting to 4.7.1 instead of 4.2.0 as before. It makes it possible to pull this axis into the test matrix on CI, see below.CI
windows-2019image to improve runtime significantly (100%).Style
DeprecationWarning: invalid escape sequence.With kind regards,
Andreas.
Footnotes
After resolving Problem invoking the test suite on macOS #343 and https://github.com/mfussenegger/cr8/pull/337, we will be able to also run the integration tests on the corresponding operating systems. ↩