Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA: Add software tests and CI configuration for Jupyter Notebooks #21

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

amotl
Copy link
Member

@amotl amotl commented Nov 2, 2024

About

Like on a few other projects, let's add software tests and a CI configuration.

  • Install Python environment and verify the Jupyter Notebooks do not break by running them to completion.
  • Nightly runs will verify that the code examples will always work, or signal when it breaks.
  • The outcome will be reflected on the Build Status page.
  • Dependabot will drive the project dependencies.

Depends on

This patch is stacked upon that one.

It means it should be merged first.

References

Similar patches about quality care.

@cla-bot cla-bot bot added the cla-signed label Nov 2, 2024
@amotl amotl mentioned this pull request Nov 2, 2024
@amotl amotl changed the base branch from main to this-and-that November 2, 2024 21:50
@amotl amotl force-pushed the testing-ci branch 3 times, most recently from 4980ba2 to 2c4437a Compare November 2, 2024 22:10
@amotl amotl force-pushed the testing-ci branch 2 times, most recently from b73c4ad to 3572023 Compare November 3, 2024 15:59
Comment on lines +4 to +7
extend-exclude = [
# TODO: Enable verifying notebooks on subsequent iteration.
"*.ipynb",
]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's let ruff format the notebooks on a later iteration. Version 0.6 gained relevant capabilities.

Base automatically changed from this-and-that to main November 4, 2024 11:02
@amotl amotl marked this pull request as ready for review November 4, 2024 12:31
Copy link
Collaborator

@simonprickett simonprickett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - feel free to merge when ready @amotl

@amotl amotl merged commit 4fe0cd7 into main Nov 4, 2024
3 checks passed
@amotl amotl deleted the testing-ci branch November 4, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants