Set initial frame when animation is changed #976
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to have single-frame animations (just to keep the logic simple in my game). E.g. while a move state might have multiple frames, an idle state just shows a single frame.
However, I noticed in such cases the animation would not be updated. Initially, I thought I did something wrong but couldn't figure it out. Then I looked into the codebase and noticed a small issue. When an animation is set, the initial frame is not yet configured. It will only change after an update, which would only happen for multi-frame animations.
This small change ensures the initial frame is configured as soon as the animation is set. This way, the correct sprite is also immediately shown for the new animation.
Perhaps these issues are related: