Ability to paginate with feeds that provide a page number instead of the next page URL. #821
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the ability to check the next page URL for the case where a page number is provided instead of the next page's URL. Some feeds only provide the current page information instead of the URL to the next page. Example of such feed below:
In this case, we are checking if the data provided as the next page is numeric, and a total page number is provided as well. In this case, we generate a URL using the
feedUrl
and appending the query string?page={number}
by incrementing the current page number. This is then repeated until the total page count provided is reached.What is included:
setupPaginationUrl($array, $feed)
function in theDataType
class, making use of theUrlHelper
function to add the query stringWhat is not included
In general, help in testing would be appreciated.
Related Issues
I apologise for not creating an issue before, but I needed this feature anyway for a project I'm working on.