Fix stock import for Product Variants #1490
Conversation
src/elements/CommerceProduct.php
Outdated
| if (!$inventoryItem) { | ||
| // Not tracking, never mind! | ||
| continue; | ||
| } |
There was a problem hiding this comment.
One thing I didn't consider when writing this (but I think is working as intended) is what would happen if the import itself turned on inventoryTracked for a variant. Given that at this stage of the import, the variant has been saved with its native attributes, the inventory item would exist already… right?
There was a problem hiding this comment.
(Yes, it does! Pushed another commit that rearranges some tests and clarifies how we're determining whether stock can/should be updated.)
Edit: I originally only saw one place we were saving an inventory item—but a record is always created as soon as a purchasable is saved. This means both that the existence of an InventoryItem record isn't really an indication of anything, and I ought to have been checking for $variant->inventoryTracked from the beginning!
Description
Fixes issues with importing variants for new products and various properties (including stock) for new variants.
Fixes issues with updating the variant‘s properties.
Related issues
#1457