Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename mapping from parent to parentId #1313

Open
wants to merge 1 commit into
base: 5.x
Choose a base branch
from

Conversation

boudewijn-zicht
Copy link
Contributor

@boudewijn-zicht boudewijn-zicht commented May 8, 2023

The attribute parentId is used in Craft to signify the value of the parent element, if any. Therefore, the mapping handle should also be parentId.

This patch changes the mapping handle from parent into parentId. This allows the comparison code to properly verify that an existing parent already exists. Without this patch the current comparison will use the parent property that does not exist in a Craft entry. This should have been parentId which does exist.

A migration is included to rename parent to parentId in any existing migrations that may already exist.

The attribute `parentId` is used in Craft to signify the value of the
parent element, if any.  Therefore, the mapping handle should also be
`parentId`.

This patch changes the mapping handle from `parent` into `parentId`.
This allows the comparison code to properly verify that an existing
parent already exists.  Without this patch the current comparison will
use the `parent` property that does not exist in a Craft entry.  This
should have been `parentId` which does exist.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant