Skip to content

Commit

Permalink
Merge branch '4.x' into 5.x
Browse files Browse the repository at this point in the history
  • Loading branch information
@timkelty
timkelty committed Aug 27, 2024
2 parents b89cfa4 + 1c73e64 commit c1326e3
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 10 deletions.
5 changes: 0 additions & 5 deletions composer.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,6 @@
"craftcms/generator": "^2.0.0",
"yiisoft/yii2-shell": "^2.0.3"
},
"autoload": {
"psr-4": {
"modules\\": "modules/"
}
},
"config": {
"allow-plugins": {
"craftcms/plugin-installer": true,
Expand Down
5 changes: 0 additions & 5 deletions composer.json.default
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,6 @@
"craftcms/generator": "^2.0.0",
"yiisoft/yii2-shell": "^2.0.3"
},
"autoload": {
"psr-4": {
"modules\\": "modules/"
}
},
"config": {
"allow-plugins": {
"craftcms/plugin-installer": true,
Expand Down

5 comments on commit c1326e3

@aelvan
Copy link

@aelvan aelvan commented on c1326e3 Sep 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nooooooooo...

@timkelty
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nooooooooo...

It wasn't being bootstrapped by app.php any longer, so it wasn't doing much good (and causing problems, in fact).

@aelvan
Copy link

@aelvan aelvan commented on c1326e3 Sep 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. But it's been there since the dawn of time, so there will be someone out there who relies on it, which will cause new problems. 🤷‍♂️

No biggie, just tired of all these changes that "shouldn't be a problem". But is. In the real world.

@brandonkelly
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aelvan Craft Generator will add the root namespace automatically when you run make module, which most people are using now since it’s included by default and the starter doesn’t include a predefined module anymore.

@aelvan
Copy link

@aelvan aelvan commented on c1326e3 Sep 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know. I still wasted time trying to figure out why our bootstrapper didn't work anymore, and fixing it. All those things can be true at the same time.

Please sign in to comment.