Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed renderPdfForOrder() method error on null $pdf #3292

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Fixed renderPdfForOrder() method error on null $pdf #3292

merged 2 commits into from
Oct 13, 2023

Conversation

nfourtythree
Copy link
Contributor

Description

The method states $pdf argument is nullable but the code expects it to exist.

Related issues

#2633

@nfourtythree nfourtythree self-assigned this Oct 9, 2023
@nfourtythree nfourtythree requested a review from a team as a code owner October 9, 2023 09:01
@nfourtythree nfourtythree mentioned this pull request Oct 9, 2023
Closed
@what-the-diff
Copy link

what-the-diff bot commented Oct 9, 2023

PR Summary

  • Enhancement of getRenderLanguage Method in Pdfs Service
    The method was updated to handle scenarios where no specific PDF is mentioned or if the PDF is not available. In such cases, the system would default to the originalLanguage setting, improving the app's capability to manage unexpected situations and ensuring a smoother user experience.

@nfourtythree nfourtythree merged commit 259e429 into develop Oct 13, 2023
4 of 8 checks passed
@nfourtythree nfourtythree deleted the bugfix/pdf-render-method branch October 13, 2023 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nfourtythree nfourtythree

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nfourtythree