Optionally allow a shippingMethod to be associated with a ShippingMethodOption #3274
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Craft Commerce's
ShippingMethodOption
erases the information of any customShippingMethod
s that were used to create them. While not ideal, this change sets a new field,shippingMethod
on theShippingMethodOption
class and also proxies the call togetShippingRules
to use the attachedShippingMethod
if it is present.Of course, other functions such as
getName
,getType
, etc will not be overridden and would need to be accessed like$option->shippingMethod->getType()
.With this change the following snippet works with Commerce built-ins and custom shipping methods:
Related issues