Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flex field layout tweaks #16303

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Flex field layout tweaks #16303

merged 1 commit into from
Dec 10, 2024

Conversation

brandonkelly
Copy link
Member

Description

Amends field widths so that:

  • Four column grids are used when the container is >= 800px wide
  • Two-column grids are used when the container is 400–799px wide
  • In two-column grids, 25%-width fields are displayed at 50%-width; all other fields are full-width.

This sortof repurposes the width setting within field layout components. Previously the widths were always taken literally, and would be respected or not based on whether the grid had enough columns to accommodate it. So 50%-width fields were always going to be 50%-width within two/four-column grids, so their physical size could resemble a 25%-width field on smaller screens – which could be too small for the field UI.

Now, width settings determine the maximum physical size of the field, on grids that happen to have room to spare. 25% equates to >=200px; 50% equates to >= 400px; and 75% equates to >=600px. Since a two-column grid is going to have columns that are at most 399px wide, all but 25%-width fields will just end up growing to 100% width.

Related issues

@brandonkelly brandonkelly merged commit 62f46d7 into 5.6 Dec 10, 2024
3 checks passed
@brandonkelly brandonkelly deleted the feature/16296-flex-field-tweaks branch December 10, 2024 14:27
brandonkelly added a commit that referenced this pull request Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant