Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/15634 spinner styles #15654

Merged
merged 6 commits into from
Sep 4, 2024
Merged

Bugfix/15634 spinner styles #15654

merged 6 commits into from
Sep 4, 2024

Conversation

i-just
Copy link
Contributor

@i-just i-just commented Sep 4, 2024

Description

  • Brings the spinner to the top layer so it contrasts with the opaque background.
  • Brings back the missing --elements-busy-top-position variable (used in the _main.scss and the BaseElementIndex.js file).
  • Use the variable mentioned above instead of the equivalent value for the inset-inline-start property of the spinner.

Related issues

#15634

@i-just i-just requested a review from brandonkelly September 4, 2024 08:16
@brandonkelly
Merge branch '5.x' into bugfix/15634-spinner-styles
e287ac5 
# Conflicts:
#	src/web/assets/cp/dist/css/cp.css
#	src/web/assets/cp/dist/css/cp.css.map
@brandonkelly
Release note
aff609d 
[ci skip]
@brandonkelly brandonkelly merged commit 5c92113 into 5.x Sep 4, 2024
@brandonkelly brandonkelly deleted the bugfix/15634-spinner-styles branch September 4, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandonkelly brandonkelly Awaiting requested review from brandonkelly

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@i-just @brandonkelly