db/backup/restore refinements #14921
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timkelty
commented
May 2, 2024
| ->addArg('--single-transaction') | ||
| ->addArg('{file}'); | ||
| } | ||
|
|
There was a problem hiding this comment.
When using pg_restore, these args need to be on the restore, regardless if the backup was created with them.
timkelty
commented
May 2, 2024
src/db/pgsql/Schema.php
Outdated
| @@ -172,7 +186,7 @@ public function getDefaultRestoreCommand(): string | |||
|
|
|||
| return $this->_pgpasswordCommand() | |||
| . $command->getExecCommand() | |||
| . '< "{file}"'; | |||
| . ($this->usePgRestore() ? '' : '< "{file}"'); | |||
There was a problem hiding this comment.
Can't use STDIN with pg_restore, because directory is a valid input.
timkelty
commented
May 2, 2024
| if (!is_file($path)) { | ||
| $this->stderr("Backup file doesn't exist: $path" . PHP_EOL); | ||
| if (!is_readable($path)) { | ||
| $this->stderr("Backup path doesn't exist: $path" . PHP_EOL); |
There was a problem hiding this comment.
Account for a possible directory (pg_restore)
# Conflicts: # src/console/controllers/DbController.php # src/db/pgsql/Schema.php
|
See #14931 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#14897 tied the format set for backups (
backupCommandFormat) with what is used for restoring, which is not ideal.This PR:
backupCommandFormatfrom what is used for restore--formatoptions fordb/restoreanddb/backup(for PG)db/restore, if no--formatis passed, it will attempt to detect which pg_restore format should be used (custom,directory,tar)db/restorecan be a directory, which is applicable for pg_restore.