Merge pull request #14911 from craftcms/bugfix/cms-14510-nested-eleme…

…nts-js-violation Fix nested elements js violation
craftcms · May 1, 2024 · f479fc3 · f479fc3
2 parents 3597752 + e5ec60c
commit f479fc3
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Release Notes for Craft CMS 4
 
+## Unreleased
+
+- Fixed a bug where disclosure menus weren’t releasing their `scroll` and `resize` event listeners on hide. ([#14911](https://github.com/craftcms/cms/pull/14911]), [#14510](https://github.com/craftcms/cms/issues/14510))
+
 ## 4.9.0 - 2024-04-30
 
 ### Content Management

diff --git a/src/web/assets/garnish/dist/garnish.js b/src/web/assets/garnish/dist/garnish.js
diff --git a/src/web/assets/garnish/dist/garnish.js.map b/src/web/assets/garnish/dist/garnish.js.map
diff --git a/src/web/assets/garnish/src/DisclosureMenu.js b/src/web/assets/garnish/src/DisclosureMenu.js
@@ -264,6 +264,8 @@ export default Base.extend(
       }
 
       this.trigger('hide');
+      this.removeListener(Garnish.$scrollContainer, 'scroll');
+      this.removeListener(Garnish.$win, 'resize');
       Garnish.uiLayerManager.removeLayer();
     },