Fixed #14320

craftcms · Feb 7, 2024 · 8610a81 · 8610a81
1 parent ea5fa4d
commit 8610a81
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,7 @@
 - Fixed a bug where element actions weren’t working for elements that were added to a relational field.
 - Fixed a bug where very wide tables could bleed off the page.
 - Fixed an error that occurred when activating a new user. ([#14316](https://github.com/craftcms/cms/issues/14316))
+- Fixed a bug where newly-added components could be selected multiple times by component selects. ([#14320](https://github.com/craftcms/cms/issues/14320))
 
 ## 5.0.0-alpha.13 - 2024-02-06
 

diff --git a/src/web/assets/cp/dist/cp.js b/src/web/assets/cp/dist/cp.js
diff --git a/src/web/assets/cp/dist/cp.js.map b/src/web/assets/cp/dist/cp.js.map
diff --git a/src/web/assets/cp/src/js/ComponentSelectInput.js b/src/web/assets/cp/src/js/ComponentSelectInput.js
@@ -492,10 +492,10 @@ Craft.ComponentSelectInput = Garnish.Base.extend(
 
       if (addToMenu && disclosureMenu) {
         const $menuItem = $(data.menuItems[type][id]);
+        disclosureMenu.addItem($menuItem);
         if (canAdd) {
-          $menuItem.addClass('hidden');
+          disclosureMenu.hideItem($menuItem.children()[0]);
         }
-        disclosureMenu.addItem($menuItem);
         this.addListener($menuItem.find('button'), 'activate', () => {
           this.addComponent(type, id);
         });