Merge pull request #15723 from craftcms/bugfix/xss-chips

Update `innerHtml` to `innerText`
craftcms · Sep 12, 2024 · 243c899 · 243c899
2 parents 396407f + a0cbcbc
commit 243c899
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -8,6 +8,7 @@
 - Fixed a bug where relation fields weren’t merging uploaded asset IDs with the existing field values. ([#15707](https://github.com/craftcms/cms/issues/15707))
 - Fixed a styling issue with inline-editable Matrix block tabs. ([#15703](https://github.com/craftcms/cms/issues/15703))
 - Fixed an RCE vulnerability.
+- Fixed an XSS vulnerability.
 
 ## 5.4.2 - 2024-09-06
 

diff --git a/src/web/assets/cp/dist/cp.js b/src/web/assets/cp/dist/cp.js
diff --git a/src/web/assets/cp/dist/cp.js.map b/src/web/assets/cp/dist/cp.js.map
diff --git a/src/web/assets/cp/dist/css/cp.css b/src/web/assets/cp/dist/css/cp.css
diff --git a/src/web/assets/cp/dist/css/cp.css.map b/src/web/assets/cp/dist/css/cp.css.map
diff --git a/src/web/assets/cp/src/js/CraftElementLabel.js b/src/web/assets/cp/src/js/CraftElementLabel.js
@@ -93,7 +93,7 @@ class CraftElementLabel extends HTMLElement {
       whiteSpace: 'nowrap',
       fontFamily: 'inherit',
     });
-    tag.innerHTML = text;
+    tag.innerText = text;
 
     this.appendChild(tag);
     const result = tag.clientWidth;