Merge pull request #16495 from craftcms/bugfix/srcset-urls

Unset name/handle for srcset size transforms
craftcms · Jan 22, 2025 · 012948a · 012948a
2 parents 60a5221 + b3e9867
commit 012948a
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,7 @@
 
 - Fixed a bug where all multi-byte characters were getting stripped out of search indexes. ([#16457](https://github.com/craftcms/cms/issues/16457))
 - Fixed a bug where Color fields weren’t translating color palette labels.
+- Fixed a bug where `craft\elements\Asset::getSrcset()` (and `srcset` method arguments) weren’t producing the correct transform URLs if the asset already had a named transform applied to it. ([#16486](https://github.com/craftcms/cms/issues/16486))
 
 ## 5.6.0.2 - 2025-01-21
 

diff --git a/src/elements/Asset.php b/src/elements/Asset.php
@@ -1958,6 +1958,8 @@ public function getUrlsBySize(array $sizes, mixed $transform = null): array
 
             $sizeTransform = $transform ? $transform->toArray() : [];
 
+            unset($sizeTransform['name'], $sizeTransform['handle']);
+
             if ($unit === 'w') {
                 $sizeTransform['width'] = (int)$value;
             } else {

diff --git a/src/services/ImageTransforms.php b/src/services/ImageTransforms.php
@@ -428,6 +428,8 @@ public function eagerLoadTransforms(array $assets, array $transforms): void
                         ...$refTransform->toArray(),
                 ]);
 
+                unset($transform->name, $transform->handle);
+
                 if ($sizeUnit === 'w') {
                     $transform->width = (int)$sizeValue;
                 } else {