Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add data-config attr to the div containing input field #289

Merged
merged 4 commits into from
Oct 19, 2024
+4 −0
Merged

add data-config attr to the div containing input field #289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
53e404d
add data-config attr to the div containing input field
i-just Sep 11, 2024
e83fde1
Merge branch '3.x' into feature/284-field-data-config-attribute
brandonkelly Oct 19, 2024
57891ee
Merge branch '3.x' into feature/284-field-data-config-attribute
brandonkelly Oct 19, 2024
6c165e9
Release note
brandonkelly Oct 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
## Unreleased

- The `ckeditor/convert/redactor` command now ensures that it’s being run interactively.
- CKEditor container divs now have `data-config` attributes, set to the CKEditor config’s handle. ([#284](https://github.com/craftcms/ckeditor/issues/284))
- Fixed a bug where page breaks were being lost.
- Fixed a bug where menus within overflown toolbar items weren’t fully visible. ([#286](https://github.com/craftcms/ckeditor/issues/286))

Expand Down
3 changes: 3 additions & 0 deletions src/Field.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,6 +477,9 @@ protected function inputHtml(mixed $value, ElementInterface $element = null): st
'class' => array_filter([
$this->showWordCount ? 'ck-with-show-word-count' : null,
]),
'data' => [
'config' => $this->ckeConfig,
],
]);
}

Expand Down