normalize pre tags after redactor conversion #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Redactor and CKEditor use slightly different markup for code block content. Redactor wraps such content in a
<pre>tag, while CKEditor requires<pre><code class="language-{langId}">by default. This means that all<pre>tags that are not followed by a<code>tag need to be normalised to contain them.To prevent this normalisation from interfering with custom configuration of the CKEditor code block feature, the code will only convert
<pre>to<pre><code class="language-plaintext">if the<pre>tag is not immediately followed by the<code>tag.Original Redactor field:
Redactor field converted to a CKEditor field before this PR:
Redactor field converted to a CKEditor field with this PR:
Related issues
#258