Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clarification and example of config options #255

Merged
merged 4 commits into from
Aug 15, 2024
Merged

clarification and example of config options #255

merged 4 commits into from
Aug 15, 2024

Conversation

i-just
Copy link
Contributor

@i-just i-just commented Jun 19, 2024

Description

Adds a note and example on how you can tweak the CKEditor’s Config Options.

Related issues

n/a

@i-just i-just requested a review from brandonkelly as a code owner June 19, 2024 18:43
@i-just i-just requested a review from AugustMiller June 19, 2024 18:44
AugustMiller
AugustMiller approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@AugustMiller AugustMiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great example! I took a pass at the surrounding text, and added a second example for a question I'd seen come up a few times (re: external links).

I'm comfortable with where it stands!

@i-just
Copy link
Contributor Author

i-just commented Jun 24, 2024

Thanks, August!

@brandonkelly brandonkelly merged commit 353c12a into 3.x Aug 15, 2024
5 checks passed
@brandonkelly brandonkelly deleted the feature/config-options-in-readme branch August 15, 2024 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AugustMiller AugustMiller AugustMiller approved these changes

@brandonkelly brandonkelly Awaiting requested review from brandonkelly brandonkelly is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@i-just @AugustMiller @brandonkelly